Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD#0000: feat: Move var-exporter into main requirements #3662

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

valguss
Copy link
Contributor

@valguss valguss commented Aug 4, 2023

  • Bug fix Magento 2 - Outdated generated code #3652 moves var-exporter from dev-requirments to requirements

  • New feature?

  • BC breaks?

  • Tests added?

  • Docs added?

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

@antonmedv
Copy link
Member

Can we do this without var-exporter?

@valguss
Copy link
Contributor Author

valguss commented Aug 4, 2023

Think I was asked to use it. Will update to remove now

@valguss
Copy link
Contributor Author

valguss commented Aug 4, 2023

Updated to var_export

@torhoehn
Copy link
Contributor

torhoehn commented Aug 4, 2023

@valguss Could you please resolve the conflicts here to get it merged?

@valguss
Copy link
Contributor Author

valguss commented Aug 4, 2023

Always useful.

@antonmedv antonmedv merged commit 4dc20ce into deployphp:master Aug 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magento 2 - Outdated generated code
3 participants