Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of elapsed time in section markers in gitlab #3664

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

bk-tba
Copy link
Contributor

@bk-tba bk-tba commented Aug 7, 2023

According to this https://docs.gitlab.com/ee/ci/jobs/#custom-collapsible-section, we need to provide a unix timestamp in seconds, not in milliseconds.

This is a reduced raw output of a deployer-job i just ran:

�[32;1mSkipping Git submodules setup�[0;m
section_end:1691389375:get_sources
�[0Ksection_start:1691389375:download_artifacts
�[0K�[0K�[36;1mDownloading artifacts�[0;m�[0;m
�[32;1mDownloading artifacts for build_release_frontend (431863)...�[0;m
...
section_end:1691389376:download_artifacts
[...]
�[0Ksection_start:1691389377467:1691389377467[collapsed=true]
�[0Kdeploy:setup
�[0Ksection_end:1691389379794:1691389377467
�[0K

As you can see, the output generated by gitlab itself has 10-digit-timestamps, but the output generated by deployer is based on millis. This leads to misleading runtimes:
image
All of this actions took less than a few secongs but being displayed as various minutes.

According to this https://docs.gitlab.com/ee/ci/jobs/#custom-collapsible-section, we need to provide a unix timestamp in seconds, not in milliseconds.
@antonmedv antonmedv merged commit e3faebe into deployphp:master Aug 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants