Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating cron jobs first time #3729

Merged
merged 1 commit into from Nov 21, 2023
Merged

Conversation

ioanok
Copy link
Contributor

@ioanok ioanok commented Nov 21, 2023

When the cronjobs are set for the first time, only identifiers ("###< $identifier" and "###> $identifier") are added to crontab, not the list of jobs. This is because of the PHP union operator (+). For indexed arrays + operator completely ignores the second array and returns the first array as it is. Using array_merge or spread operator should be the right way to contact local jobs with remote ones.

  • [x ] Bug fix #…?
  • New feature?
  • BC breaks?
  • Tests added?
  • Docs added?

…operator completely ignores the second array and returns the first array as it is.
@antonmedv antonmedv merged commit a0a21e2 into deployphp:master Nov 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants