Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento2 theme processing fix for 3786 #3818

Merged
merged 10 commits into from
Apr 24, 2024
Merged

Conversation

akosglue
Copy link
Contributor

@akosglue akosglue commented Apr 22, 2024

with the following configuration in deploy.php

set('static_content_jobs', '16');
set('static_content_locales', 'nl_BE fr_BE');
set('split_static_deployment', false);

it produces the following output for these cases (when running magento:deploy:assets):

set('magento_themes', []);
-->
.../current/bin/magento setup:static-content:deploy -f --content-version=1713786990  nl_BE fr_BE  -j 16
set('magento_themes', ['Magento/luma', 'Custom/another']);
-->
.../current/bin/magento setup:static-content:deploy -f --content-version=1713787032  nl_BE fr_BE  -t Magento/luma -t Custom/another -j 16
set('magento_themes', [
    'Magento/blank'   => 'nl_BE',
    'Magento/luma'   => null,
    'myvendor/theme-at' => 'de_AT',
    'myvendor/theme-be' => 'fr_BE nl_BE',
    'Custom/another' => '{{static_content_locales}} it_IT',
]);
-->
.../current/bin/magento setup:static-content:deploy -f --content-version=1713787073  nl_BE fr_BE  -t Magento/blank -t Magento/luma -t myvendor/theme-at -t myvendor/theme-be -t Custom/another -j 16

note that the languages are not taken from the associative array but from the 'static_content_locales' parameter, but this is only when 'split_static_deployment' is false

@antonmedv antonmedv merged commit 22e95ba into deployphp:master Apr 24, 2024
8 of 9 checks passed
midweste pushed a commit to midweste/deployer that referenced this pull request Jun 1, 2024
* origin/master: (40 commits)
  Improve the configuration options console output in provision:configure (deployphp#3840)
  Update Craft CMS deploy recipe (deployphp#3839)
  [automatic] Update docs with bin/docgen
  Update provision.php
  Feature/UI enhancements (deployphp#3835)
  Hotfix/v7.4.0: Fixes caddyfile and realpath errors in provision:website (deployphp#3837)
  [automatic] Update docs with bin/docgen
  docs(recipe/shopware): add code syntax highlighting (deployphp#3834)
  [automatic] Update docs with bin/docgen
  docs(recipe/magento2): fix typo in conccurent (deployphp#3830)
  [automatic] Update docs with bin/docgen
  magento2 theme processing fix for 3786 (deployphp#3818)
  use md5 of task name for section id in gitlab ci (deployphp#3817)
  [automatic] Update docs with bin/docgen
  Magento 2: Changed upgrading database (deployphp#3812)
  [automatic] Update docs with bin/docgen
  Shopware: Added `deploy:update_code` (deployphp#3816)
  [automatic] Update docs with bin/docgen
  Update nodejs to LTS version (deployphp#3815)
  Update LICENSE
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants