Update to json schema v6 #3860
Draft
Update to json schema v6 #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running this test in isolation caused issues when calling Deployer::get() as the underlying $instance was still uninitialised
… smoke testing as part of the version 6 release of json-schema
|
So can we try to update? |
We are planning to release the v6 soon. Once available I can update this PR to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-schemaintegration.This Draft PR is part of the smoke testing of the json-schema v6 release. The smoke testing entails seeing if any issues arise when updating the biggest (by stars) dependencies to the
v6.0.0-beta. Obviously this should not be merged in this state, but the pipeline results might help us catch any issues early on.The question for now would be to approve the pipeline in order to see the results.