Update deploy:writable_dirs: When running WITHOUT sudo, exec setfacl once only

[vanquang9387]

When run deploy:writable_dirs WITHOUT sudo, exception maybe thrown if setfacl run on files created by http user (in directory that has been setfacl before). These directories/files should be skipped.

Ref: #433 (comment)

[antonmedv]

Cool! I'm going to merge. Can any one to test it? @oanhnn @deployphp/maintainer ?

[antonmedv]

@vanquang9387 can you add more comments here, why this is necessary.

[vanquang9387]

@Elfet
On first deploy:

setfacl -R -m u:"apache":rwX -m u:`whoami`:rwX app/webroot/images

Then, apache creates files:

$ ll current/app/webroot/images/
total 112
-rw-r--r--. 1 apache apache 34821 Aug 21 17:07 1440144423_main.png
-rw-r--r--. 1 apache apache 34821 Aug 21 17:07 1440144423.png
-rw-rw-r--+ 1 apache apache 34821 Aug 21 17:07 1440144441_55d6dc39ce799.png

Next, exec setfacl on next deploy will throw runtime exception:

Run: cd /var/www/html/project/releases/20150821170801 &&  setfacl -R -m u:"apache":rwX -m u:`whoami`:rwX app/webroot/images

  Unable to setup correct permissions for writable dirs.
  You need co configure sudo's sudoers files to don't prompt for password,
  or setup correct permissions manually.

  [RuntimeException]
  setfacl: app/webroot/images/1440144441_55d6dc39ce799.png: Operation not permitted
  setfacl: app/webroot/images/1440144423_main.png: Operation not permitted
  setfacl: app/webroot/images/1440144423.png: Operation not permitted

I mentioned this problem here: #433 (comment)

Do you need more comments in the code?

[vanquang9387]

@Elfet comments added 🌟

[vanquang9387]

ping @Elfet

[oanhnn]

This PR has some issues:

• This code dose not care user:www-data:r-- or user:www-data:rwx. It alway return a number greater than 0.
• This code dose not care user www-data (apache user) and user www-data2 (other user)
• If setfacl is exist with group ???

And one issue of Deployer:

• Check deployer user and apache user is same user 😄

[vanquang9387]

@oanhnn Please check my new commit.
I think problem that "httpd user is the same user or same group with deployer user" is not related to setfacl. This should be checked at the beginning of writable task if needed.

[oanhnn]

Thank you!

[svycka]

This still has a problem it does not check recursively for example with a config like this:

set('shared_dirs', [
    'data/tmp'
]);
set('writable_dirs', [
    'data',
]);

will fail because acl is set on data/tmp and files within but this PR only checks if data/ has acl set or not.