Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding artisan migration helpers #541

Closed
wants to merge 1 commit into from
Closed

Conversation

filpgame
Copy link

Adding Laravel's artisan migration helpers

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets n/a

Adding Laravel's artisan migration helpers
@oanhnn
Copy link
Contributor

oanhnn commented Jan 29, 2016

Please edit comment and prepend table

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets n/a

Migartion should be executed without option --force

@antonmedv
Copy link
Member

Agree, no --force.

@filpgame
Copy link
Author

filpgame commented Feb 5, 2016

But without --force in production environment, the migration command will be canceled, cause the command asks for a confirmation

@oanhnn oanhnn added the feature label Feb 17, 2016
@antonmedv
Copy link
Member

Is --force used only for asks for a confirmation? May be there is an not-interactive mode?

@philbates35
Copy link

Pretty sure all --force does is to automatically proceed when it asks for confirmation. @FlipGame is right, without it the command would be cancelled.

@barryvdh barryvdh mentioned this pull request Apr 11, 2016
6 tasks
@barryvdh
Copy link
Contributor

Agreed, you need --force.

Perhaps also add php artisan db:seed and a php artisan migrate:status to check before running migrate?

Not sure if it's possible to do the confirm on the Deployer side, to be safe?

@antonmedv
Copy link
Member

It's possible, but what happens if you run php artisan migrate --force if there no migrations?

@philbates35
Copy link

It just says "nothing to migrate". Force is purely just to get past the "you're in production, are you you sure you want to do this?" prompt.

@antonmedv
Copy link
Member

Do we need deploy:migrate in deploy task?

@barryvdh
Copy link
Contributor

Do we need deploy:migrate in deploy task?
I wouldn't do that by default.

@oanhnn oanhnn mentioned this pull request Apr 12, 2016
@oanhnn
Copy link
Contributor

oanhnn commented Apr 12, 2016

I think this problem will be resolved in #622
Thank you @filpgame about your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants