Allows people to use other release names like tag without replacing t… #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask deploy:release
|
This is very useful feature, but with this place a lot of problems (like different timezones between developers), to it's must be refactored at all. |
|
@Elfet This commit simply moved the $release = date("YmdHis"); out of the task to an env() key. If your developers have different timezones this change allows you to make a new env value which uses timezone. Or like me to use the git tag as release. |
|
Ok, i think it's ok. What do you think @oanhnn ? |
|
👍 I agree merge this feature. It is OK. |
oanhnn
pushed a commit
that referenced
this pull request
Mar 14, 2016
Allows people to use other release names like tag without replacing t…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow people to name release folders (to tag) without replacing task deploy:release .