Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always success #950

Merged
merged 2 commits into from Jan 16, 2017
Merged

always success #950

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3421114
always success
ad3n Jan 11, 2017
82cd13c
Use -f to avoid error when file is not exist
ad3n Jan 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion recipe/deploy/lock.php
View file
Open in desktop
Expand Up @@ -23,5 +23,8 @@

desc('Unlock deploy');
task('deploy:unlock', function () {
run("rm {{deploy_path}}/.dep/deploy.lock");
try {
run("rm {{deploy_path}}/.dep/deploy.lock");//always success
} catch (\Exception $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's bad solution to mute all errors, better to use bash or rm options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i change to use -f instead of try catch block

}
});