Meta linting #88
Merged
Meta linting #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I look towards automated liniting in Travis, I want to make sure that tests aren't going to break in unexpected fashions when the upstream test tooling is updated unexpectedly. Thus we lock these version using the output of `pip list --format freeze`. This means that these version will need to be periodically updated to capture the latest & greatest work, but those updates will happen in a controlled fashion (a git commit).
Although we had readme instructions referencing this, the version to use was not specified in requirements_test.txt. Lock it! Also, max-line-length = 100 per @deppen8's preferred style.
@deppen8 uses black for formatting all the code in this repo. Instead of having flake8 fight with it, lets officially add black to the toolchain.
The black version in the toolchain reflowed this file. In order to prevent PR build failure we need to fix in in the repo.
wadells
commented
Feb 10, 2020
reqs/lint.txt
Outdated
| pycodestyle==2.5.0 | ||
| pyflakes==2.1.1 | ||
|
|
||
| # flake8, top level |
There was a problem hiding this comment.
copypasta error: flake8 -> black
thomasjohns
previously approved these changes
Feb 10, 2020
There was a problem hiding this comment.
LGTM :) One thing we could add if desired is a README badge for black code style like https://github.com/psf/black#show-your-style.
deppen8
previously approved these changes
Feb 10, 2020
This will categorically prevent flake8 or black regressions from entering the code base in the future. Fixes deppen8#83.
Trying to install zipp==2.2.0 on 3.5 results in the following error: Could not find a version that satisfies the requirement zipp==2.2.0 (from versions: 0.1.0, 0.2.0, 0.2.1, 0.3.0, 0.3.1, 0.3.2, 0.3.3, 0.4.0, 0.5.0, 0.5.1, 0.5.2, 0.6.0, 1.0.0, 1.1.0)
Co-Authored-By: Jacob Deppen <deppen.8@gmail.com>
Co-Authored-By: Jacob Deppen <deppen.8@gmail.com>
wadells
force-pushed
the
meta-linting
branch
from
49f263b
to
0141f79
Compare
deppen8
approved these changes
Feb 10, 2020
Closed
keturn
added a commit
to keturn/pandas-vet
that referenced
this pull request
Feb 11, 2020
post-merge of deppen8#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces flake8 and black to the toolchain and ensures they are run against every pull request.
Fixes #83.
In fact, this will categorically prevent #83 from ever regressing.
Testing done:
I enabled Travis on my fork. All pushes to this branch can be seen here:
https://travis-ci.org/wadells/pandas-vet/builds?utm_medium=notification&utm_source=github_status
It is currently green.
Furthermore, I also nuked & rebuilt my venv to test setup instructions.