This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Update markups and fix #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just started reviewing :) |
Sent from 
carloslancha
suggested changes
Dec 26, 2017
There was a problem hiding this comment.
Since class .sticker has position: relative adding a span inside with .sticker-overlay should not be a problem. Go for it, add it as default wrapper on all stickers, remove it from ClayUserCard and update the ussage by passing imageSrc to it. Nice catch @matuzalemsteles !
Btw... stop working and enjoy your holidays!! 😂
| @@ -72,7 +72,21 @@ | |||
| {@param? imageAlt: string} | |||
| {@param? imageSrc: string} | |||
There was a problem hiding this comment.
In fact this two params should be mandatory for this .image template, so we can get rid of let and just place the variables in the image, or at least remove the conditions.
|
Resent #237 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @carloslancha,
ClayUserCardcustomize thelabelofClayStickermean that we are duplicating the markup, but it is obliged to use thesticker-overlayclass in the label to be positioned correctly, we can add as default inClayStickerbut I do not know what effects it can cause it being used on other components. What do you think about this?