This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Update ClayButton markup #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloslancha
suggested changes
Dec 27, 2017
| {/if} | ||
| {/let} | ||
|
|
||
| {let $iconContent kind="html"} |
There was a problem hiding this comment.
Refactor all this, please. You're defining $iconContent and $iconWrapper even when they would be not used.
| @@ -57,20 +57,42 @@ | |||
| {@param? label: html|string} | |||
| {@param? spritemap: string} | |||
|
|
|||
| {let $classes kind="text"} | |||
There was a problem hiding this comment.
Define variables right before using them.
|
Just started reviewing :) |
Sent from
|
Resent #238 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary that do not add a
spanwhen you just want to render an icon, this causes some unwanted behaviors in some components like ClayLabel.