This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Create ClayPagination and ClayPaginationBar #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
carloslancha
commented
Jan 13, 2018
•
edited
edited
Hey @matuzalemsteles! Here I've tried to make all of the rendering in soy to make possible server-side rendering. Take a look and tell me your thoughts;) |
Hey @matuzalemsteles, I'm going to merge this because I want to push forward with the clay reunification, so this is likely to be the last PR in this repo before we move everything to http://github.com/liferay/clay |
hey @carloslancha, Good job with rendering on SSR. But just pointing out a few points.
What do you think? |
Hey @matuzalemsteles I'll take a look on that bug, didn't notice, thx! I've preferred for now not to add those events till we need it. We can easily add it in the future. EDIT: Fixed here #265 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.