Skip to content
This repository has been archived by the owner on Jan 16, 2018. It is now read-only.

Create ClayPagination and ClayPaginationBar #263

Merged
merged 25 commits into from
Jan 15, 2018
Merged

Create ClayPagination and ClayPaginationBar #263

merged 25 commits into from
Jan 15, 2018

Conversation

carloslancha
Copy link
Collaborator

@carloslancha carloslancha commented Jan 13, 2018

captura de pantalla 2018-01-13 a las 18 01 57

@carloslancha carloslancha changed the title SF Create ClayPagination and ClayPaginationBar Jan 13, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 81.306% when pulling 1a6d390 on carloslancha:ClayPagination into eb105d4 on metal:master.

@carloslancha
Copy link
Collaborator Author

Hey @matuzalemsteles! Here I've tried to make all of the rendering in soy to make possible server-side rendering. Take a look and tell me your thoughts;)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.618% when pulling fa6eb4d on carloslancha:ClayPagination into eb105d4 on metal:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.618% when pulling 009a98a on carloslancha:ClayPagination into 371d3b8 on metal:master.

@jbalsas
Copy link
Contributor

jbalsas commented Jan 15, 2018

Hey @matuzalemsteles, I'm going to merge this because I want to push forward with the clay reunification, so this is likely to be the last PR in this repo before we move everything to http://github.com/liferay/clay

@jbalsas jbalsas merged commit 96a151b into deprecate:master Jan 15, 2018
@matuzalemsteles
Copy link
Collaborator

hey @carloslancha, Good job with rendering on SSR. But just pointing out a few points.

  • When we reach more than 6 pages and currentPage is the last page, the range ends up adding more than it should.

screen shot 2018-01-15 at 10 21 33

  • We may have to trigger some events when there are clicks on the items.
  • Will we let SPA always load pages when there is user interaction or are we going to give the possibility that devs will load the data when events are triggered? since it can gain some "performance" ... Using the events triggered by pagination.

What do you think?

@carloslancha
Copy link
Collaborator Author

carloslancha commented Jan 15, 2018

Hey @matuzalemsteles I'll take a look on that bug, didn't notice, thx!

I've preferred for now not to add those events till we need it. We can easily add it in the future.

EDIT: Fixed here #265

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants