Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

[ModularRouting] looking for maintainer? where to go next? deprecate? #181

Closed
TomasVotruba opened this issue Jun 12, 2017 · 11 comments
Closed

Comments

@TomasVotruba
Copy link
Member

TomasVotruba commented Jun 12, 2017

I'm doing CLI & backend apps mostly, so I don't use routing much and not really this way.
I'd like to focus on development of few packages and I know I won't have my attention for this one as much as I'd love it to have.

I think this package might be very useful for many years on, sice this feature was missed since Symfony 1.

I'm looking for somebody, who would take care of this package and cultivate it in near future.

I also it's been here for over 2 years and has very few downloads. Maybe time for deprecation?

What do you say?

@TomasVotruba
Copy link
Member Author

Do you use this package or how do you deal with routes huge applications?
/cc @enumag @fprochazka @tomasfejfar

@enumag
Copy link
Member

enumag commented Jun 13, 2017

We're using annotations in controllers. Personally I don't like that approach but is was like that before I even joined the team. There are plenty more important things I need to fix so it's not a priority.

@tomasfejfar
Copy link
Contributor

We also use annotations. Only issue is maintainability and discovery, but we solved that by rigorous naming conventions, that hint the developer to the location. Also with PhpStorm's Symfony plugin it works great with autocomplete, refactoring, etc.

@TomasVotruba TomasVotruba changed the title [ModularRouting] looking for maintainer [ModularRouting] looking for maintainer? where to go next? deprecate? Jun 13, 2017
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jun 14, 2017

Thanks for feedback guys. I got feeling this bundle has no use (which is fine), since there are more usable ways to do so. Morover with Symfony 4 and Flex.

@tomasfejfar It sounds interesting. What exact naming conventions did you use? Could you share code snippets before/after?

Related to this topic: there is also new feture in Symfony 3.4, that turns route annotation loading on.

I've prepared the deprecation PR, but I wait for more feedback and ideas.

@TomasVotruba
Copy link
Member Author

I'd like to ask you your opinion, since you've involved in discussion under post.

@hhamon @javiereguiluz @iltar

@tomasfejfar
Copy link
Contributor

There was no "before" as we anticipated it ;)

currently we have @Route("/", name="module_controller_snake_case_action") and @Route("/module/controller/snake-case-action", service="project.app_bundle.module.controller.controller-class") in the controller. In few particullar cases where one action responds to multiple routers we use meaningful suffix for each.

@TomasVotruba
Copy link
Member Author

@tomasfejfar Thanks for sharing. It reminds me how is Symfony plugin powerful.

@linaori
Copy link

linaori commented Jun 14, 2017

When using annotation routing and you use PSR service discovery and tag the controllers properly, you pretty much have this but automatically and compiled, if I understand it correctly.

@TomasVotruba TomasVotruba added this to the 2.0 milestone Jun 14, 2017
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jun 14, 2017

@iltar I think you're right. What do you mean by "tagging controllers properly"? Is that needed to load their routes?

@linaori
Copy link

linaori commented Jun 14, 2017

@TomasVotruba it provides method injection for services only afaik, not required for the actual concept.

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jun 14, 2017

@iltar I see. Personally I prefer invocable controllers with ctor.

Thank you all for feedback and input. I see there is no need for this package now, so I've deprecated it: #182

@deprecated-packages deprecated-packages locked as resolved and limited conversation to collaborators Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants