-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maintainers and transfer ownership #25
Comments
UDS is being included in |
Ah, missed that change. |
@alexcrichton looks like there’s interest in ownership. Pinging here because I would like the PR you commented on merged since it fixes tokio on illumos. Edit: |
If the tokio/mio folks are willing to move this repository over as a means of transferring maintainership, that seems like it would work. Otherwise, either @posborne and/or @jclulow and I are interested in stepping up to help with this work. @alexcrichton What's your preferred course of action? |
I don't mind transferring this repo and the crate, would someone like to volunteer to take ownership of the repo and crate? |
Folding it under the @tokio-rs org seems like a natural fit, considering it's one of the primary consumers. Does that seem palatable to the core folks there (ping @carllerche @Thomasdezeeuw)? @jclulow and I are certainly interested in stepping up to help with maintenance if the added burden is a concern. |
@pfmooney are you talking about maintain Mio-uds for Mio v0.6? Because as @carllerche mentioned in v0.7 Mio supports UDS, e.g. see https://docs.rs/mio/0.7.0/mio/net/struct.UnixDatagram.html. I haven't used this crate so I can't say for sure, but I think missing API in Mio v0.7 (w.r.t UDS) can be added easily. |
Also cc @kleimkuhler who added support for UDS to Mio. |
|
@pfmooney I understand the need to support Tokio, but couldn't we keep Mio-uds as is and say the next version is rolled into Mio? Deprecating (but still supporting) Mio-uds and suggesting Mio's UDS types instead? |
Considering other direct |
Is Mio-uds currently not working with Mio v0.6? Like I said before it can be deprecated, suggesting people to move to Mio v0.7, while maintaining Mio-uds (for Mio v0.6). As an aside I personally don't plan on supporting Mio v0.6 very long, preferably the ecosystem moves to v0.7 (which close to a v1 in terms of API) this year. Do note that this is my personal opinion and I'm not the only maintainer of Mio, so others might have different plans. |
Agreed. That's why @jclulow and I are interested in putting in the work to keep it viable while
I agree that widespread adoption of the new version would be ideal. Until the new version reaches the point of ubiquity, it would be nice to to continue the maintenance for 0.6 in order to at least accept minor fixes like these platform-enabling patches, provided they don't seem to risky. |
@alexcrichton If you're interested in handing over maintenance, @jclulow and I are happy to pick it up via the same @deprecrated effort proposed for |
Sure, what do I need to do to help with that? |
Looking at Transferring a repository, it seems like:
I think if you add either Patrick or myself as an owner on this repository, we could then effect the transfer as we would have rights both here and there. As for crates.io, I assume you just have to add either of our GitHub accounts as able to publish for the crate and we can then do whatever subsequent ACL change is required. I haven't done one of those transfers myself yet though, so I do not know exactly which buttons to push. |
Er I meant where is the repository transferred to and what does the example of net2 look like. I can handle all the details I just need to know exactly what the details are. |
Oh, sorry! Our intent is for For this crate I would expect it to move to Is that the right sort of detail? If not, please let me know and I can answer whatever you need! Thanks for your help so far. |
Ok sounds good to me! Want me to transfer the repo to you @jclulow then and I'll add you on crates.io? Looks like net2 is a done deal so I can go ahead and do this too. |
I've invited you to @deprecrated where you should have the rights to initiate the transfer. |
Ok! I've added @pfmooney as an owner on crates.io and transferred the repository. |
Much appreciated. Thanks for your help. |
mio-uds
continues to be used (I think correctly) as part of the crate graph for tokio-net but is currently lacking active maintainership (see #23 (comment)). I am actively actively making use of the crate (via tokio) and would be willing to take over as a maintainer for this code.I think an argument could be made for moving the repo to the tokio-rs org which would give team members in that org the commit bit as well.
CC @carllerche @alexcrichton
The text was updated successfully, but these errors were encountered: