illumos/solaris should use SOCK_CLOEXEC|SOCK_NONBLOCK #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
libc PR: rust-lang/libc/pull/1594 |
|
Thanks for the PR, but unfortunately I don't have the time to maintain this crate any more. If there's a willing contributor I can transfer ownership! |
|
Looks like there is an offer to maintain this crate in #25 |
|
I hit this issue today and the patch from @papertigers fixed it. It would be great if this gets integrated. |
|
Fixed in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this was broken on illumos while working on a tokio issue.
Calling the following on illumos will result in EINVAL --
try!(cvt(libc::ioctl(fd.fd, libc::FIOCLEX)));We support
SOCK_CLOEXECandSOCK_NONBLOCK, although it looks like those currently are not in the libc crate, so I will open a PR there as well to get those added.That means we can merge this or wait for the libc changes to get merged and bump the libc dependency in this crate. Either works for me.