Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add illumos support #101

Closed
wants to merge 2 commits into from
Closed

add illumos support #101

wants to merge 2 commits into from

Conversation

jclulow
Copy link
Member

@jclulow jclulow commented Apr 14, 2020

Previously, illumos systems used the "x86_64-sun-solaris" host triple.
Now that we're getting an "x86_64-unknown-illumos" triple, we need to
add new target_os conditionals for illumos.

With this change I'd like to get a new version, 0.2.34, published to crates.io so that we can start using it in other repositories. Thanks for taking a look!

Previously, illumos systems used the "x86_64-sun-solaris" host triple.
Now that we're getting an "x86_64-unknown-illumos" triple, we need to
add new target_os conditionals for illumos.
@jclulow
Copy link
Member Author

jclulow commented Apr 15, 2020

For what it's worth, though the CI environment appears to be having difficulty, the tests do pass on an Ubuntu system:

$ cargo test
    Updating crates.io index
   Compiling libc v0.2.69
   Compiling cfg-if v0.1.10
   Compiling net2 v0.2.33 (/var/tmp/net2-rs)
    Finished test [unoptimized + debuginfo] target(s) in 2.96s
     Running target/debug/deps/net2-4f33690d22f7d589

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/all-2fc00eaa4aab24f2

running 2 tests
test smoke_build_listener_v6 ... ok
test smoke_build_listener ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests net2

running 1 test
test src/lib.rs -  (line 27) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

@jclulow
Copy link
Member Author

jclulow commented Apr 15, 2020

Hi @alexcrichton! Sorry to bug you, but I'd really appreciate it if you could take a look at this one. I recognise maintenance on this crate appears to have slowed, but it's still in use in a number of important and popular libraries for right now. If I can help with maintenance or whatever, please let me know! Thanks.

@alexcrichton
Copy link
Contributor

Sorry but I don't maintain this crate any more.

@jclulow
Copy link
Member Author

jclulow commented Apr 15, 2020

Sorry but I don't maintain this crate any more.

Fair enough! Do you know who does? I don't see much information about how projects in the "rust-lang-nursery" organisation are intended to work.

If you're looking to pass maintenance on, I'd be happy to create a new GitHub organisation and take it over with @pfmooney. We'd really like to get a release of this out -- it's used in a number of very active other crates!

Thanks.

@Amanieu Amanieu mentioned this pull request Apr 22, 2020
7 tasks
@pfmooney
Copy link
Member

pfmooney commented May 1, 2020

Addressed in 24f41cb

@pfmooney pfmooney closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants