refactor: Camera, Mission, Members UseCase 리펙토링 #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Camera Entity 네이밍 수정 - Members UseCase 책임 분리 - Members Entity 네이밍 수정
…into refactor/#562-camera-usecase-logic-modify * 'develop' of https://github.com/depromeet/14th-team5-iOS: refactor: rename usecase and entities at presentation(#560) refactor: post usecase(#560) refacotr: realEmoji usecase(#560) refactor: reaction(#560) [refactor]: mainView usecase(#560) feat: 코드 리뷰 반영 (#555) feat: BaseContainer, BaseWrapper 코드 구현 (#538) feat: 공통 헤더 삽입 코드 수정 (#555) feat: SignInRepositoryProtocol 구현 (#555) feat: SignInHelper 구현, TokenKeychain이 SignInType을 저장하도록 수정 (#555) feat: 구 SignIn 코드 이름을 Account로 변경 (#555) feat: TokenKeychain, OAuthRepository 구현 (#555) feat: 주석 추가 (#555) refactor: SignIn 관련 Helper 코드 리팩토링 (#555) feat: OAuth 관련 APIWoker, DTO 구현 (#555) refactor: Calendar 관련 UseCase 코드 리팩토링 (#538) feat: 순환 참조 문제 수정 (#538) feat: CalendarDIContainer 예시 코드 작성 (#538) feat: DIContainer 구현 (#538)
- Mission Entity 네이밍 수정 - 사용하지 않는 Mission Repository Protocol 파일 제거 - asObservable 메서드 제거
rlarjsdn3
reviewed
Jun 17, 2024
| return CameraDisplayViewReactor(provider: globalState, cameraDisplayUseCase: makeUseCase(), displayData: displayData, missionTitle: missionTitle, cameraType: cameraDisplayType) | ||
| return CameraDisplayViewReactor( | ||
| provider: globalState, | ||
| createPresignedCameraUseCase: CreateCameraUseCase(cameraRepository: makeRepository()), |
There was a problem hiding this comment.
나중에 Provider도 @injected 로 받아오심 되여~
rlarjsdn3
reviewed
Jun 17, 2024
| import RxCocoa | ||
|
|
||
| public protocol FetchCameraRealEmojiUploadUseCaseProtocol { | ||
| func execute(memberId: String, parameter: CameraCreateRealEmojiParameters) -> Single<CameraCreateRealEmojiEntity?> |
There was a problem hiding this comment.
혹시 Single Trait 반환하면 flatMap 연산자 쓰면 오류 안나시나요? 그것 땜시 전 Observable로 했는데
rlarjsdn3
approved these changes
Jun 18, 2024
akrudal
added a commit
that referenced
this pull request
Jun 21, 2024
akrudal
added a commit
that referenced
this pull request
Jun 21, 2024
akrudal
added a commit
that referenced
this pull request
Jun 21, 2024
akrudal
added a commit
that referenced
this pull request
Jun 23, 2024
akrudal
added a commit
that referenced
this pull request
Jun 23, 2024
akrudal
added a commit
that referenced
this pull request
Jun 23, 2024
akrudal
added a commit
that referenced
this pull request
Jun 23, 2024
akrudal
added a commit
that referenced
this pull request
Jun 23, 2024
akrudal
added a commit
that referenced
this pull request
Jun 23, 2024
Do-hyun-Kim
added a commit
that referenced
this pull request
Jun 23, 2024
…into feat/#567-add-wraaper-inject * 'develop' of https://github.com/depromeet/14th-team5-iOS: rebase feat: dicontainer(#565) [feat]: wrapper and dependency folder(#565) [feat]: add wrapper(#565) feat: private으로 접근제어자 수정 (#552) feat: private으로 접근제어자 수정 (#547) feat: FamilyDIContainer 구현 (#547) feat: SignInDIContainer 구현 (#547) feat: OAuthDIContainer 구현 (#547) feat: PickDIContainer 구현 (#552) feat: CommentDIContainer 구현 (#552) fix: Keychain의 Key 추가, RefreshToken 갱신 문제 수정 (#564) refactor: CommentUseCase 코드 리팩토링 (#553) refactor: PickUseCase 코드 리팩토링 (#553) refactor: SignInUseCase 코드 리팩토링 (#553) refactor: OAuthUseCase 코드 리팩토링 (#553) refactor: FamilyUseCase 코드 리팩토링 (#553) refactor: CalendarUseCase 코드 리팩토링 (#553) # Conflicts: # 14th-team5-iOS/App/Sources/Application/AppDelegate.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
execute메서드를 호출 할 수 있도록 책임 분배 하였습니다.Entity로 리펙토링 하였습니다.MissionRepositoryProtocol로 통합 시켰습니다.MissionAPIWorker에서getTodayMission메서드는 호출하고 있지 않기 때문에 제거하였습니다.변경 로직 ⚒️
MissionRepositoryProtocol로 통합 시켰습니다. @akrudal 확인 부탁드립니다.getTodayMission메서드 역시 호출 하고 있는 부분이 없어서 제거 하였습니다.테스트 케이스 ✅