새로고침 시에도 추가 질문 유지 #168
Merged
새로고침 시에도 추가 질문 유지 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle SizesCompared against be296b6 Route: No significant changes found Dynamic import: No significant changes found |
hyesungoh
approved these changes
May 26, 2023
src/hooks/storage/useLocalStorage.ts
Outdated
Comment on lines
40
to
50
| const [hasMounted, setHasMounted] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| setHasMounted(true); | ||
| }, []); | ||
|
|
||
| if (hasMounted) { | ||
| return [storedValue, setValue] as const; | ||
| } | ||
|
|
||
| return [initialValue, setValue] as const; |
There was a problem hiding this comment.
Suggested change
| const [hasMounted, setHasMounted] = useState(false); | |
| useEffect(() => { | |
| setHasMounted(true); | |
| }, []); | |
| if (hasMounted) { | |
| return [storedValue, setValue] as const; | |
| } | |
| return [initialValue, setValue] as const; | |
| const isMounted = useRef(false); | |
| useDidMount(() => { | |
| isMounted.current = true; | |
| }); | |
| if (isMounted.current) { | |
| return [storedValue, setValue] as const; | |
| } | |
| return [initialValue, setValue] as const; |
이렇게 useRef와 useDidMount를 사용하면 어떨까요??
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 92.39% 92.52% +0.13%
==========================================
Files 38 38
Lines 276 281 +5
Branches 51 52 +1
==========================================
+ Hits 255 260 +5
Misses 21 21
☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
957387e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://759cb68a.na-lab.pages.dev |
| Branch Preview URL: | https://feat-create-dialog.na-lab.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
�새로고침 시에도 추가 질문 유지
🎉 변경 사항
useLocalStorage훅을 사용하였어요.useLocalStorage훅에서 hydration 오류가 발생해, 해결하였습니다.