DNA 페이지 이미지 로직 변경 #451
Merged
DNA 페이지 이미지 로직 변경 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle SizesCompared against 1077694 Route: No significant changes found
|
hyesungoh
requested review from
oyeon-kwon,
sjoleee and
sumi-0011
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 44 44
Lines 338 338
Branches 61 61
=======================================
Hits 302 302
Misses 36 36 ☔ View full report in Codecov by Sentry. |
sumi-0011
approved these changes
Nov 2, 2023
sumi-0011
reviewed
Nov 2, 2023
Comment on lines
+47
to
+56
| style={{ | ||
| width: '375px', | ||
| height: '666px', | ||
| }} | ||
| src={HOISTING_IMAGE_BY_GROUP[group as Group]} | ||
| alt={'dna_' + group} | ||
| width={375} | ||
| height={666} | ||
| /> | ||
| <span |
There was a problem hiding this comment.
다운받는 사진의 화질이 안좋은 문제는 이부분에서 사진 비율에 맞게 이미지 자체 크기를 키우면 되지 않을까 싶어요!
There was a problem hiding this comment.
width={375}
height={666}
이부분을 2, 3배수로 바꾸서 확인해보면 좋을 것 같습니다!
There was a problem hiding this comment.
이미지 안의 요소들이 절대 주소로 되어 있어서, 다음 PR에 나눠서 해보겠읍니다 ~~ 의견 감사드려용 👍
hyesungoh
commented
Nov 3, 2023
There was a problem hiding this comment.
dynamic load를 위해 파일을 분리했어요
Comment on lines
+97
to
+100
| imageDownloadPC( | ||
| `/api/dna-image?group=${group}&nickname=${userInfo?.nickname}&position=${userInfo?.position}`, | ||
| 'dna', | ||
| ); |
There was a problem hiding this comment.
api route를 이용해 이미지를 저장해요
Comment on lines
181
to
185
| <DNAImageDownloadModal | ||
| downloadableBase64={downloadableImage.base64} | ||
| imageSrc={`/api/dna-image?group=${group}&nickname=${userInfo?.nickname}&position=${userInfo?.position}`} | ||
| isShowing={isImageModalShowing} | ||
| onClose={() => setIsImageModalShowing(false)} | ||
| /> |
There was a problem hiding this comment.
api route를 이용해 이미지를 렌더링해요
|
개선 이전
개선 이후
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
🎉 변경 사항
API route를 이용해서 필요할 때 이미지를 동적으로 만들도록 했어요
Modal을 lazy load 해 초기 이미지 요청을 지연시켜요