Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat : add getNearItemPoints api #35

Merged
merged 7 commits into from
May 20, 2023
Merged

✨ feat : add getNearItemPoints api #35

merged 7 commits into from
May 20, 2023

Conversation

seonghun-dev
Copy link
Collaborator

Resolve: #34

@seonghun-dev seonghun-dev added the ✨feature New feature or request label May 19, 2023
@seonghun-dev seonghun-dev added this to the 1차 스프린트 milestone May 19, 2023
@seonghun-dev seonghun-dev self-assigned this May 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023 •
edited

Codecov Report

Merging #35 (6636343) into main (e6d55fd) will increase coverage by 21.62%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              main      #35       +/-   ##
============================================
+ Coverage     9.41%   31.03%   +21.62%     
- Complexity       6       26       +20     
============================================
  Files           16       23        +7     
  Lines           85      116       +31     
============================================
+ Hits             8       36       +28     
- Misses          77       78        +1     
- Partials         0        2        +2
Impacted Files Coverage Δ
...op/domains/common/validator/LatitudeValidator.java 50.00% <50.00%> (ø)
...p/domains/common/validator/LongitudeValidator.java 50.00% <50.00%> (ø)
...meet/streetdrop/domains/item/dao/ItemPointDao.java 88.88% <88.88%> (ø)
...treetdrop/apis/item/controller/ItemController.java 100.00% <100.00%> (ø)
...t/streetdrop/domains/item/service/ItemService.java 100.00% <100.00%> (ø)
...promeet/streetdrop/global/error/dto/ErrorCode.java 90.00% <100.00%> (+90.00%) ⬆️

... and 4 files with indirect coverage changes

@siyeonSon siyeonSon mentioned this pull request May 20, 2023
Closed
2 tasks
@seonghun-dev seonghun-dev merged commit 32b6605 into main May 20, 2023
1 check passed
@seonghun-dev seonghun-dev deleted the feature/item-poi branch May 20, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunyoung1819 yunyoung1819 yunyoung1819 approved these changes

@siyeonSon siyeonSon siyeonSon approved these changes

Assignees

@seonghun-dev seonghun-dev

Labels
✨feature New feature or request
Projects
None yet
Milestone
1차 스프린트
Development

Successfully merging this pull request may close these issues.

Add Get Near Item Points API
4 participants
@seonghun-dev @codecov-commenter @yunyoung1819 @siyeonSon