홈 화면 - 추가 버튼 개발 #116
Merged
홈 화면 - 추가 버튼 개발 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 16.28% 16.29% +0.01%
==========================================
Files 102 106 +4
Lines 866 902 +36
Branches 130 131 +1
==========================================
+ Hits 141 147 +6
- Misses 701 731 +30
Partials 24 24
|
ddarkr
approved these changes
May 5, 2022
맞아요!! 메인 페이지 스타일링은 이거 전에 날린 PR에서 해결되었어요!! 머지 후에도 테스트 해보겠슴다 👍 👍 |
|
@hyesungoh 오 이미 해결된 부분이였군요...!!! 죄송합니다 😂 굳이에요~!! 👍 |
Deploying with
|
| Latest commit: |
895fd53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a43e515a.ygt.pages.dev |
Closed
2 tasks
positiveko
approved these changes
May 7, 2022
| @@ -2,7 +2,7 @@ import { useMemo } from 'react'; | |||
| import { useRouter } from 'next/router'; | |||
| import { UrlObject } from 'url'; | |||
|
|
|||
| export type RouterPathType = `/` | '/test'; | |||
| export type RouterPathType = `/` | '/test' | '/add/link' | '/add/text' | '/add/image'; | |||
|
고생하셨습니다 :) ⚡️⚡️⚡️⚡️⚡️⚡️⚡️⚡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️작업 내용
홈 화면의 Append Button을 추가했어요 (framer상 floating button)
눌렸을 때 나오는 Tooltip을 개발했어요
RouterPathType을 추가하여 적용했어요Image,Link아이콘을 추가했어요resetcss > a 태그에cursor: pointer옵션을 추가했어요📸스크린샷
⚡️확장 방향
현재 쓰이고 있는
PortalWrapper를 확장하여backdrop과 함께position: fixed인 wrapper를 개발해보면 좋을 거 같다고 느꼈어요!🔥 이슈 공유
#114 에서 확인하실 수 있듯이, forwardRef 경고를 받았었는데, 링크된 아티클에서도 말하듯 html 태그로 감싸주어 현재는 경고를 발생시키지 않네요!! 나중에 필요해질 때 적용해보면 좋을 거 같아용