홈 화면 - 네비게이션 바 + 태그 추가 개발 w/ 공용 훅 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
requested review from
sensecodevalue,
ddarkr and
positiveko
as code owners
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 15.58% 14.76% -0.83%
==========================================
Files 108 118 +10
Lines 943 1009 +66
Branches 143 152 +9
==========================================
+ Hits 147 149 +2
- Misses 771 829 +58
- Partials 25 31 +6
|
ddarkr
reviewed
May 8, 2022
Comment on lines
+3
to
+13
| export default function usePreventScroll(condition: boolean = true) { | ||
| useEffect(() => { | ||
| if (typeof document === 'undefined') return; | ||
| if (condition) document.body.style.overflow = 'hidden'; | ||
| else document.body.style.overflow = 'unset'; | ||
|
|
||
| return () => { | ||
| document.body.style.overflow = 'unset'; | ||
| }; | ||
| }, [condition]); | ||
| } |
Closed
|
filteredTags 변경 |
Deploying with
|
| Latest commit: |
237e0ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f227f162.ygt.pages.dev |
positiveko
approved these changes
May 8, 2022
| export default function HomeNavigationBar() { | ||
| return ( | ||
| <nav css={navCss}> | ||
| <Link href="/?modal=tag" as="/tag" scroll={false}> |
Comment on lines
+3
to
+13
| export default function usePreventScroll(condition: boolean = true) { | ||
| useEffect(() => { | ||
| if (typeof document === 'undefined') return; | ||
| if (condition) document.body.style.overflow = 'hidden'; | ||
| else document.body.style.overflow = 'unset'; | ||
|
|
||
| return () => { | ||
| document.body.style.overflow = 'unset'; | ||
| }; | ||
| }, [condition]); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️작업 내용
작업 기간이 기간이니,,, 나눠서 개발할 수도 있었지만 개발 진척도를 위해 뭉쳐서 개발했슴다
홈화면에 대한 부분
/tagroute를 홈 화면에서 사용되는 태그 관리 route로 사용했습니다 + Route as modal로써 사용했습니다components/home/TagFormRouteAsModal에서 query param을 기준으로 모달을 보여주었습니다. (children으로 page 컴포넌트를 렌더링합니다)공통되는 부분
TagForm이TagFrom으로 돼 있어서 오타 수정했슴다useQueryParam훅을 개발했습니다usePreventScroll훅을 개발했슴니다📸스크린샷
⚡️사용 방법
📎공유
NOTE:달아놨어용appliedTags를 사용하고 있어요. 영감 추가나 편집시에 태그가 비어있어야 한다면 특정 라우트 진입하거나, 언마운트시에 리셋하는 로직을 추가해야합니다!! (리코일 리셋 훅)