Skip to content
This repository has been archived by the owner on Aug 22, 2020. It is now read-only.

Add linter #28

Closed
mjpitz opened this issue Jan 21, 2019 · 0 comments
Closed

Add linter #28

mjpitz opened this issue Jan 21, 2019 · 0 comments
Assignees
@mjpitz
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
0.0.4

Comments

@mjpitz
Copy link
Member

mjpitz commented Jan 21, 2019

Right now, we don't use a linter and we really should. I know there is a good number of things that will fail the linters check. Todo:

  • add linter to make target
  • swap travis build over to using the make targets
  • fix issues identified by linter
@mjpitz mjpitz added enhancement New feature or request help wanted Extra attention is needed labels Jan 21, 2019
@mjpitz mjpitz added this to the 0.0.4 milestone Jan 21, 2019
@mjpitz mjpitz self-assigned this Jan 21, 2019
mjpitz added a commit that referenced this issue Jan 21, 2019
@mjpitz
gh-28: moved over to using make targets in travis
87e2945
mjpitz added a commit that referenced this issue Jan 22, 2019
@mjpitz
gh-28: added golint to the test flow and cleaned up linter issues
39e84e4
mjpitz pushed a commit that referenced this issue Jan 22, 2019
gh-28: added linter (#31)
365a282 
* gh-28: moved over to using make targets in travis

* gh-28: added golint to the test flow and cleaned up linter issues
@mjpitz mjpitz closed this as completed Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjpitz mjpitz

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
0.0.4
Development

No branches or pull requests
1 participant
@mjpitz