Import NFT from non-custodial wallet #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smonn
changed the title
smonn
requested review from
dallashuggins,
afraser,
davidjmurphyjr,
jakerainis and
a team
davidjmurphyjr
approved these changes
Feb 17, 2022
... but requires a lot of cleanup also intend to modify the export flow to match the transaction group etc
smonn
force-pushed
the
smonn/import-collectibles
branch
from
6c53551
to
e497b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import flow for NFTs. It can be found in a user's profile page (for now). The flow is very similar to the export one.
Also included some changes to the export flow to match how transactions are created and signed in separate steps with this new code.