This repository has been archived by the owner on Nov 26, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 7
Add random jitter to scan and join delay to appear more natural #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egative integers, apparently..?
…egative integers, apparently..?
…egative integers, apparently..?
…egative integers, apparently..?
depthbomb
suggested changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea, however it should be an opt-in feature that the user can turn on in their settings.
… is now a private field, and variable names have been corrected.
…t for the extra settings fields. Depending on OS theme the scrollbar can be barely visible, and most people are using at least 1366x768 nowadays so this seems like a justifiable enough change.
…ed together. Also adjusted TabIndex attributes so that the form can be navigated smoothly rather than jumping back to the Auto-increment checkbox midway through.
Merge dev branch into master
Thanks for the feedback! I've made these changes now, and I've set the default for the jitter options to be zero to make it opt-in. I also took the liberty of adjusting the default window size to accomodate the extra fields and fixed up the TabIndexes since they were a little out of whack. Let me know if anything else needs adjusting! |
depthbomb
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is a small change to RaffleService to add some minor randomisation to the delays, after a friend of mine suggested it.
Simply put, it varies how often it scans by up to 60 seconds each time, and raffle join frequency by up to 10 seconds, effectively turning. This has two benefits:
No other changes are made other than this, but it seems like it could be useful so I figured I'd throw a PR in rather than keep it as an offshoot. Thanks!