Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Improve Rails' error handling #207

Closed
jgarber623-gov opened this issue Dec 1, 2017 · 2 comments
Closed

Improve Rails' error handling #207

jgarber623-gov opened this issue Dec 1, 2017 · 2 comments
Assignees

Comments

@jgarber623-gov
Copy link
Contributor

jgarber623-gov commented Dec 1, 2017

From the Puma logs, we're seeing some things like:

Error during failsafe response: Missing template errors/not_found, application/not_found with {:locale=>[:en], :formats=>[:pdf], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby]}. Searched in:
  * "/var/app/current/app/views"

I think the errors_controller code isn't properly capturing 404s for non-HTML resources. This may be solvable by adding via: :all to the 404 route.

We should also improve the test code to attempt to load miscellaneous 404s.

From some quick searching, a couple URLs that might be helpful:

@jgarber623-gov
Copy link
Contributor Author

After some digging around, it seems like using exceptions_app isn't the preferred way of handling application errors. rails/rails#19913 and rails/rails#17815 have some details as to why.

@aileendds aileendds mentioned this issue Dec 22, 2017
6 tasks
@jgarber623-gov
Copy link
Contributor Author

Resolved by #268.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant