-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically adding release notes from changelog #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things.
changelog=$"$changelog\n$line" | ||
fi | ||
fi | ||
done <CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This errors if the file does not already exist. See #13
The Java script has been tested/verified manually. See https://github.com/dequelabs/testing-repo/releases/tag/v3.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM... I have one comment (below) but I assume you've thought of this and I'm probably missing something so I am approving 😄
I have 0 experience working with/in this repo, plus I'm no shell script expert so I could be missing something but it seems we could extract the get_changelog()
function into it's own file (say get_changelog.sh
) and "import" it in each script via source get_changelog.sh
.
NOTE: get_changelog.sh
needs to be in one of the directories in $PATH; if it's not, you'll need to specify an absolute path
Yep, that would be ideal, but it would be a breaking change, as we'd have to update all of our CI configurations to fetch that file as well. We figured a little copypasta here was better than updating all 12,000,062 repositories. |
Used @stephenmathieson function to add changelog content to Github release for attest-ruby/java/node
Test results
attest-java
:https://github.com/dequelabs/attest-java/blob/develop/CHANGELOG.md
Test results
attest-ruby
:https://github.com/dequelabs/attest-ruby/blob/develop/CHANGELOG.md
Test results
attest-node-suite
:https://github.com/dequelabs/attest-node-suite/blob/develop/CHANGELOG.md
Closes issue: https://github.com/dequelabs/HTMLToolsTeamHub/issues/70
Reviewer checks
Required fields, to be filled out by PR reviewer(s)