Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove axe-matchers lib & spec files #112

Merged
merged 6 commits into from
Jul 14, 2020
Merged

chore: remove axe-matchers lib & spec files #112

merged 6 commits into from
Jul 14, 2020

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Jul 14, 2020 •
edited by AdnoC
Loading

Removing:

  • lib
  • spec
  • and integration tests from top level

All of these have been moved to respective packages directory to respective gems.

Closes issue:

  • NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for accessibility
  • Code is reviewed for security

@jeeyyy jeeyyy requested a review from AdnoC July 14, 2020 11:31
AdnoC
AdnoC approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@AdnoC AdnoC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not what I'd call "deprecate", but looks good

@jeeyyy jeeyyy changed the title refactor: deprecate axe-matchers chore: deprecate axe-matchers Jul 14, 2020
@jeeyyy jeeyyy changed the title chore: deprecate axe-matchers chore: remove axe-matchers lib & spec files Jul 14, 2020
@jeeyyy jeeyyy merged commit 246c3d6 into develop Jul 14, 2020
@jeeyyy jeeyyy deleted the remove-matchers-code branch July 14, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdnoC AdnoC AdnoC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @AdnoC