ci: enable manual run of patch release #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
reviewed
Aug 25, 2023
.github/scripts/prepare_release.sh
Outdated
|
|
||
| sed -i -e "s/ VERSION\\s*=\\s*\"$oldVersion\"/ VERSION = \"$newVersion\"/" version.rb | ||
|
|
||
| npx conventional-changelog-cli@"$CHANGELOG_VERSION" -p angular -i CHANGELOG.md -s |
There was a problem hiding this comment.
What's the reason for skipping changelog generation in standard-version but then doing it here?
There was a problem hiding this comment.
There was a point where the version of standart-version and conventional-changelog-cli was set via environmental variable. In that case it was necessary to separate the steps. This has been changed.
straker
reviewed
Sep 7, 2023
| - name: Create release | ||
| uses: dequelabs/axe-api-team-public/.github/actions/auto-patch-release-v1@main | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| skip_checks: ${{ steps.skip-checks.outputs.value }} |
There was a problem hiding this comment.
Could you not do the expression here rather than having a separate step to do it?
Suggested change
| skip_checks: ${{ steps.skip-checks.outputs.value }} | |
| skip_checks: ${{ github.event_name != schedule }} |
There was a problem hiding this comment.
We need the string true or false, so we use the output
straker
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR: #323
Test issue: #322
Conditional checks were tested in a personal repo: https://github.com/AdnoC/action-test/actions/workflows/push-and-dispatch.yml
https://github.com/dequelabs/axe-api-team/issues/355
https://github.com/dequelabs/axe-api-team/issues/342