Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update prepare_release.sh to take optional release level #340

Merged
merged 2 commits into from Oct 4, 2023
Merged

ci: update prepare_release.sh to take optional release level #340

merged 2 commits into from Oct 4, 2023

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Oct 3, 2023

This PR allows the unnamed argument to be optional, if it's not specified it will default to commit-and-tag-version handling version, otherwise it will release as the specified release level.

Without specifying a release level image
With release level image

Closes: #337

@Zidious Zidious requested a review from a team as a code owner October 3, 2023 16:44
straker
straker previously requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to install commit-and-tag-version version and uninstall standard-version in the package.json

@Zidious Zidious requested review from straker and a team October 4, 2023 13:14
@Zidious Zidious merged commit 5c304dc into develop Oct 4, 2023
5 checks passed
@Zidious Zidious deleted the ci-prepare-release branch October 4, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update prepare_release.sh
2 participants
@Zidious @straker