Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock-fs broken in node v20.5 #788

Open
straker opened this issue Aug 9, 2023 · 0 comments
Open

mock-fs broken in node v20.5 #788

straker opened this issue Aug 9, 2023 · 0 comments
Labels
web-apis

Comments

@straker
Copy link
Contributor

straker commented Aug 9, 2023

Our node 20 cli tests are currently broken due to a bug in mock-fs which exists due to node v20.5 creating an optimization for fs.ReadFileSync that mock-fs is not compatible with. We have a few different ways we could fix this, so just need to chose one:

  • pin to node v20.4
  • remove the utf-8 option from our calls to fs.ReadFileSync in our tests
  • stop using mock-fs (only used in one file in a few tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-apis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@straker @AdnoC @dequejenn