Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gracefully handle unloaded iframes #133

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from
Open

fix: gracefully handle unloaded iframes #133

Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
56e53df
fix: gracefully handle unloaded iframes
AdnoC Oct 18, 2023
35233e1
format
AdnoC Oct 18, 2023
92245ff
add tests
AdnoC Oct 18, 2023
daeef9d
frame ready
AdnoC Oct 18, 2023
bf519df
forgot to remove this
AdnoC Oct 18, 2023
3ee748a
fix assert
AdnoC Oct 18, 2023
20528eb
format
AdnoC Oct 18, 2023
ca68075
why did format at repo root not do this file?
AdnoC Oct 18, 2023
4b5ae4e
axefixture method
AdnoC Oct 18, 2023
8f96b08
use real fixtures
AdnoC Oct 18, 2023
4220a0b
why
AdnoC Oct 23, 2023
b194257
format
AdnoC Oct 23, 2023
db86a94
asdf
AdnoC Oct 23, 2023
4d5cd75
asdf
AdnoC Oct 23, 2023
0d6c1cc
asdf
AdnoC Oct 23, 2023
9e595c1
nullable
AdnoC Oct 23, 2023
e4a38b2
hardcoded?
AdnoC Oct 23, 2023
40af6e3
move to js file
AdnoC Oct 23, 2023
183bb87
pls
AdnoC Oct 23, 2023
81fccd4
forgot to add to csproj
AdnoC Oct 23, 2023
e37b96f
pls
AdnoC Oct 23, 2023
e1696c7
ok please
AdnoC Oct 23, 2023
71c1ac5
fixed a few i thunk?
AdnoC Oct 23, 2023
78dbaec
adding to non-legacy tests
AdnoC Oct 23, 2023
72cabb9
fixed the issue
AdnoC Oct 23, 2023
e43e0ac
format
AdnoC Oct 23, 2023
9e52a39
damnit
AdnoC Oct 23, 2023
7cb5edd
added more mocks for timeouts
AdnoC Oct 23, 2023
37de26a
fix uselegacy tests
AdnoC Oct 23, 2023
92054b5
WHY DOES IT NOT PICK UP THE FRAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAME
AdnoC Oct 23, 2023
6570cde
CHROME WORKS. FF not :(
AdnoC Oct 23, 2023
7a32664
format
AdnoC Oct 23, 2023
6f66fef
restore iframe option
AdnoC Oct 23, 2023
b6db0c6
explain why test change
AdnoC Oct 23, 2023
8db86de
remove printf
AdnoC Oct 23, 2023
0e7c51b
say why no FF unloaded test
AdnoC Oct 23, 2023
3ead16b
swap to gotofixture. remove old
AdnoC Oct 23, 2023
2849c27
refactor so iframe check is just early return
AdnoC Oct 25, 2023
61486eb
make error handling better
AdnoC Oct 25, 2023
71ee3e9
why is about:blank not ready in ci?
AdnoC Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,19 @@ jobs:
- name: Install .NET Core 3.1 and 6
uses: actions/setup-dotnet@v1
with:
dotnet-version: |
dotnet-version: |
3.1.x
6.x.x

- name: Install NuGet dependencies
run: dotnet restore

- name: Check formatting
run: dotnet format --verify-no-changes

- name: Build
run: dotnet build --no-restore -c ${{ inputs.configuration }} -p:VersionSuffix=${{ inputs.version-suffix }}

- name: Test
id: test
run: |
Expand All @@ -50,7 +50,7 @@ jobs:
name: test-results
path: |
${{ github.workspace }}/packages/*/test/TestResults

- name: Prepare packages artifact
run: |
mkdir ${{ github.workspace }}/packages-artifact
Expand All @@ -62,4 +62,3 @@ jobs:
with:
name: packages
path: ${{ github.workspace }}/packages-artifact

Loading
Loading