fix(invalidrole): allow upper and mixed case role names (#4358)

Closes: #2695
dequelabs · Apr 1, 2024 · 105016c · 105016c
1 parent f89c13b
commit 105016c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/lib/checks/aria/invalidrole-evaluate.js b/lib/checks/aria/invalidrole-evaluate.js
@@ -28,7 +28,7 @@ import { tokenList } from '../../core/utils';
 function invalidroleEvaluate(node, options, virtualNode) {
   const allRoles = tokenList(virtualNode.attr('role'));
   const allInvalid = allRoles.every(
-    role => !isValidRole(role, { allowAbstract: true })
+    role => !isValidRole(role.toLowerCase(), { allowAbstract: true })
   );
 
   /**

diff --git a/test/checks/shared/invalidrole.js b/test/checks/shared/invalidrole.js
@@ -111,4 +111,33 @@ describe('invalidrole', function () {
     );
     assert.deepEqual(checkContext._data, ['foo', 'bar']);
   });
+
+  it('should return true if applied to an uppercase nonsensical role', function () {
+    var virtualNode = queryFixture(
+      '<div id="target" role="FOO">Contents</div>'
+    );
+    assert.isTrue(
+      checks.invalidrole.evaluate.call(
+        checkContext,
+        virtualNode.actualNode,
+        null,
+        virtualNode
+      )
+    );
+    assert.deepEqual(checkContext._data, ['FOO']);
+  });
+
+  it('should return false if applied to an uppercase valid role', function () {
+    var virtualNode = queryFixture(
+      '<div id="target" role="BUTTON">Contents</div>'
+    );
+    assert.isFalse(
+      checks.invalidrole.evaluate.call(
+        checkContext,
+        virtualNode.actualNode,
+        null,
+        virtualNode
+      )
+    );
+  });
 });