chore: Add tests

lib/checks/label/implicit.js

@@ -2,7 +2,6 @@ const { dom, text } = axe.commons;
 
 var label = dom.findUpVirtual(virtualNode, 'label');
 if (label) {
-	console.log(label);
 	return !!text.accessibleText(label, { inControlContext: true });
 }
 return false;

lib/commons/aria/get-aria-labelledby-text.js

@@ -32,9 +32,14 @@ aria.getAriaLabelledbyText = function getAriaLabelledbyText(
 			inLabelledByContext: true,
 			// Allow hidden content if the elm is hidden
 			includeHidden: !dom.isVisible(elm, true),
+			startNode: context.startNode || node,
 			...context
 		});
 
-		return accessibleName + ' ' + accessibleNameAdd;
+		if (!accessibleName) {
+			return accessibleNameAdd;
+		} else {
+			return accessibleName + ' ' + accessibleNameAdd;
+		}
 	}, '');
 };

lib/commons/aria/get-owned.js → lib/commons/aria/get-owned-virtual.js

@@ -1,8 +1,11 @@
 /* global aria, dom */
 aria.getOwnedVirtual = function getOwned({ actualNode, children }) {
+	if (!actualNode || !children) {
+		throw new Error('getOwnedVirtual requires a virtual node');
+	}
 	return dom.idrefs(actualNode, 'aria-owns').reduce((ownedElm, element) => {
 		if (element) {
-			let virtualNode = axe.utils.getNodeFromTree(axe._tree[0], element);
+			const virtualNode = axe.utils.getNodeFromTree(axe._tree[0], element);
 			ownedElm.push(virtualNode);
 		}
 		return ownedElm;

test/commons/aria/get-aria-label-text.js

@@ -0,0 +1,34 @@
+describe('aria.getAriaLabelText', function() {
+	'use strict';
+	var aria = axe.commons.aria;
+
+	it('returns "" if there is no aria-label', function() {
+		var node = document.createElement('div');
+		assert.equal(aria.getAriaLabelText(node), '');
+	});
+
+	it('returns the aria-label attribute of nodes', function() {
+		var node = document.createElement('div');
+		var label = ' my label ';
+		node.setAttribute('aria-label', label);
+		assert.equal(aria.getAriaLabelText(node), label);
+	});
+
+	it('returns the aria-label attribute of virtual nodes', function() {
+		var node = document.createElement('div');
+		var label = ' my label ';
+		node.setAttribute('aria-label', label);
+		const vNode = { actualNode: node };
+		assert.equal(aria.getAriaLabelText(vNode), label);
+	});
+
+	it('returns "" if there is no aria-label', function() {
+		var node = document.createElement('div');
+		assert.equal(aria.getAriaLabelText(node), '');
+	});
+
+	it('returns "" if the node is not an element', function() {
+		var node = document.createTextNode('my text node');
+		assert.equal(aria.getAriaLabelText(node), '');
+	});
+});

test/commons/aria/get-aria-labelledby-text.js

@@ -0,0 +1,117 @@
+describe('aria.getAriaLabelledbyText', function() {
+	'use strict';
+	var aria = axe.commons.aria;
+	var fixtureSetup = axe.testUtils.fixtureSetup;
+
+	it('returns the accessible name of the aria-labelledby references', function() {
+		var fixture = fixtureSetup(
+			'<div role="heading" aria-labelledby="foo"></div>' +
+				'<div id="foo">Foo text</div>'
+		);
+		var accName = aria.getAriaLabelledbyText(fixture.firstChild);
+		assert.equal(accName, 'Foo text');
+	});
+
+	it('works with virtual nodes', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo">Foo text</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target);
+		assert.equal(accName, 'Foo text');
+	});
+
+	it('returns references in order', function() {
+		var fixture = fixtureSetup(
+			'<div role="heading" aria-labelledby="bar baz foo"></div>' +
+				'<div id="foo">Foo</div>' +
+				'<div id="bar">Bar</div>' +
+				'<div id="baz">Baz</div>'
+		);
+		var accName = aria.getAriaLabelledbyText(fixture.firstChild);
+		assert.equal(accName, 'Bar Baz Foo');
+	});
+
+	it('returns "" if the node is not an element', function() {
+		var fixture = fixtureSetup('foo');
+		var accName = aria.getAriaLabelledbyText(fixture.firstChild);
+		assert.equal(accName, '');
+	});
+
+	it('returns "" with context.inLabelledByContext: true', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo">Foo text</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target, {
+			inLabelledByContext: true
+		});
+		assert.equal(accName, '');
+	});
+
+	it('returns "" with context.inControlContext: true', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo">Foo text</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target, {
+			inControlContext: true
+		});
+		assert.equal(accName, '');
+	});
+
+	it('returns content of a aria-hidden reference', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo" aria-hidden="true">Foo text</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target);
+		assert.equal(accName, 'Foo text');
+	});
+
+	it('returns content of a `display:none` reference', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo" style="display:none">Foo text</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target);
+		assert.equal(accName, 'Foo text');
+	});
+
+	it('returns does not return hidden content of a visible reference', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo"><div style="display:none">Foo text</div></div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target);
+		assert.equal(accName, '');
+	});
+
+	it('does not follow more than one aria-labelledy reference', function() {
+		fixtureSetup(
+			'<div role="heading" id="hdr" aria-labelledby="foo"></div>' +
+				'<div id="foo"><div aria-labelledby="bar" role="heading"></div></div>' +
+				'<div id="bar">Foo text</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#hdr')[0];
+		var accName = aria.getAriaLabelledbyText(target, {
+			inControlContext: true
+		});
+		assert.equal(accName, '');
+	});
+
+	it('preserves spacing', function() {
+		var fixture = fixtureSetup(
+			'<div role="heading" aria-labelledby="foo"></div>' +
+				'<div id="foo"> \t Foo \n text \t </div>'
+		);
+		var accName = aria.getAriaLabelledbyText(fixture.firstChild);
+		assert.equal(accName, ' \t Foo \n text \t ');
+	});
+});

test/commons/aria/get-owned-virtual.js

@@ -0,0 +1,47 @@
+describe('aria.getOwnedVirtual', function() {
+	'use strict';
+	var aria = axe.commons.aria;
+	var fixtureSetup = axe.testUtils.fixtureSetup;
+
+	it('returns a list of children in order', function() {
+		fixtureSetup(
+			'<div id="target">' +
+				'<h1>heading 1</h1>' +
+				'<h2>heading 2</h2>' +
+				'<h3>heading 3</h3>' +
+				'</div>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#target')[0];
+		var owned = aria.getOwnedVirtual(target);
+		assert.lengthOf(owned, 3);
+		assert.equal(owned[0].actualNode.nodeName.toUpperCase(), 'H1');
+		assert.equal(owned[1].actualNode.nodeName.toUpperCase(), 'H2');
+		assert.equal(owned[2].actualNode.nodeName.toUpperCase(), 'H3');
+	});
+
+	it('adds aria-owned reffed elements to the children', function() {
+		fixtureSetup(
+			'<div id="target" aria-owns="hdr3 hdr4">' +
+				'<h1>heading 1</h1>' +
+				'<h2>heading 2</h2>' +
+				'</div>' +
+				'<h4 id="hdr4">heading 4</h4>' +
+				'<h3 id="hdr3">heading 3</h3>'
+		);
+		var target = axe.utils.querySelectorAll(axe._tree[0], '#target')[0];
+		var owned = aria.getOwnedVirtual(target);
+		assert.lengthOf(owned, 4);
+		assert.equal(owned[0].actualNode.nodeName.toUpperCase(), 'H1');
+		assert.equal(owned[1].actualNode.nodeName.toUpperCase(), 'H2');
+		assert.equal(owned[2].actualNode.nodeName.toUpperCase(), 'H3');
+		assert.equal(owned[2].actualNode.nodeName.toUpperCase(), 'H4');
+	});
+
+	it('ignores whitespace-only aria-owned');
+
+	it('ignores broken aria-owned refs');
+
+	it('includes text nodes');
+
+	it('returns an empty array if there are no owned elements');
+});