fix(listitem): do not fail for parent with role=presentation|none

dequelabs · Jun 16, 2020 · a3ddc6e · a3ddc6e
1 parent 2176794
commit a3ddc6e
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/lib/checks/lists/listitem.js b/lib/checks/lists/listitem.js
@@ -7,7 +7,7 @@ if (!parent) {
 const parentTagName = parent.nodeName.toUpperCase();
 const parentRole = (parent.getAttribute('role') || '').toLowerCase();
 
-if (parentRole === 'list') {
+if (['presentation', 'none', 'list'].includes(parentRole)) {
 	return true;
 }
 

diff --git a/test/checks/lists/listitem.js b/test/checks/lists/listitem.js
@@ -29,6 +29,20 @@ describe('listitem', function() {
 		assert.isTrue(checks.listitem.evaluate.call(checkContext, target));
 	});
 
+	it('should pass if the listitem has a parent role=none', function() {
+		fixture.innerHTML =
+			'<ul role="none"><li id="target">My list item</li></ul>';
+		var target = fixture.querySelector('#target');
+		assert.isTrue(checks.listitem.evaluate.call(checkContext, target));
+	});
+
+	it('should pass if the listitem has a parent role=presentation', function() {
+		fixture.innerHTML =
+			'<ul role="presentation"><li id="target">My list item</li></ul>';
+		var target = fixture.querySelector('#target');
+		assert.isTrue(checks.listitem.evaluate.call(checkContext, target));
+	});
+
 	it('should fail if the listitem has an incorrect parent', function() {
 		fixture.innerHTML = '<div><li id="target">My list item</li></div>';
 		var target = fixture.querySelector('#target');

diff --git a/test/integration/rules/listitem/listitem.html b/test/integration/rules/listitem/listitem.html
@@ -7,6 +7,12 @@
 <ol>
 	<li id="alsocontained">Also belongs to a list.</li>
 </ol>
+<ul role="presentation">
+	<li id="presentation">Does belong to a list.</li>
+</ul>
+<ul role="none">
+	<li id="none">Does belong to a list.</li>
+</ul>
 <ul role="menubar">
 	<li id="ulrolechanged">Also does not belong to a list.</li>
 </ul>

diff --git a/test/integration/rules/listitem/listitem.json b/test/integration/rules/listitem/listitem.json
@@ -2,5 +2,5 @@
 	"description": "listitem test",
 	"rule": "listitem",
 	"violations": [["#uncontained"], ["#ulrolechanged"], ["#olrolechanged"]],
-	"passes": [["#contained"], ["#alsocontained"]]
+	"passes": [["#contained"], ["#alsocontained"], ["#presentation"], ["#none"]]
 }