Merge pull request #3244 from dequelabs/release-4.3.5

chore(release): 4.3.5
dequelabs · Oct 29, 2021 · a5da703 · a5da703
2 parents 505e6ba + d9ce5fb
commit a5da703
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [4.3.5](https://github.com/dequelabs/axe-core/compare/v4.3.4...v4.3.5) (2021-10-29)
+
+### Bug Fixes
+
+- **aria-allowed-attr:** revert violation for non-global ARIA attrs on element without role ([#3243](https://github.com/dequelabs/axe-core/issues/3243)) ([e138fd6](https://github.com/dequelabs/axe-core/commit/e138fd6a00a8da6c48a74a614adc5dae8f2044e1))
+
 ### [4.3.4](https://github.com/dequelabs/axe-core/compare/v4.3.3...v4.3.4) (2021-10-22)
 
 ### Bug Fixes

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "axe-core",
-  "version": "4.3.4",
+  "version": "4.3.5",
   "contributors": [
     {
       "name": "David Sturley",

diff --git a/lib/checks/aria/aria-allowed-attr-evaluate.js b/lib/checks/aria/aria-allowed-attr-evaluate.js
@@ -69,7 +69,7 @@ function ariaAllowedAttrEvaluate(node, options, virtualNode) {
   ariaAttr.forEach(attr => {
     preChecks[attr] = validateRowAttrs;
   });
-  if (allowed) {
+  if (role && allowed) {
     for (let i = 0; i < attrs.length; i++) {
       const attrName = attrs[i];
       if (validateAttr(attrName) && preChecks[attrName]?.()) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "axe-core",
   "description": "Accessibility engine for automated Web UI testing",
-  "version": "4.3.4",
+  "version": "4.3.5",
   "license": "MPL-2.0",
   "engines": {
     "node": ">=4"

diff --git a/sri-history.json b/sri-history.json
@@ -290,5 +290,9 @@
   "4.3.4": {
     "axe.js": "sha256-C62RaRaF4cx65nFcFNMq5qhRPs0K3syB/x32hxSnDFM=",
     "axe.min.js": "sha256-Qw1EkY/ShOt08vZ7tZXSskZI3bQ6HGw9t9F6Rq05MAo="
+  },
+  "4.3.5": {
+    "axe.js": "sha256-pBzsgJIL4mZHcw50O3sj5f1ZYkMYLG659lHq6Qrkuzc=",
+    "axe.min.js": "sha256-PVZfyAKgcOWwy7tmB01H7BVjKLjtFW5QO94AIXxWkcw="
   }
 }
diff --git a/test/checks/aria/allowed-attr.js b/test/checks/aria/allowed-attr.js
@@ -59,6 +59,18 @@ describe('aria-allowed-attr', function() {
     assert.isNull(checkContext._data);
   });
 
+  it('should return true for non-global attributes if there is no role', function() {
+    var vNode = queryFixture(
+      '<div id="target" tabindex="1" aria-selected="true" aria-owns="foo"></div>'
+    );
+
+    assert.isTrue(
+      axe.testUtils
+        .getCheckEvaluate('aria-allowed-attr')
+        .call(checkContext, null, null, vNode)
+    );
+  });
+
   it('should not report on invalid attributes', function() {
     var vNode = queryFixture(
       '<div role="dialog" id="target" tabindex="1" aria-cats="true"></div>'

diff --git a/test/integration/rules/aria-allowed-attr/failures.html b/test/integration/rules/aria-allowed-attr/failures.html
@@ -28,12 +28,12 @@
 <kbd aria-label="value" id="fail27"></kbd>
 <abbr aria-label="value" id="fail28"></abbr>
 <custom-elm aria-label="value" id="fail29"></custom-elm>
-<audio
+<!-- <audio
   src="/test/assets/moon-speech.mp3"
   controls
   aria-orientation="horizontal"
   id="fail30"
-></audio>
+></audio> -->
 
 <div role="table">
   <div role="row" aria-expanded="false" id="fail35"></div>

diff --git a/test/integration/rules/aria-allowed-attr/failures.json b/test/integration/rules/aria-allowed-attr/failures.json
@@ -31,7 +31,6 @@
     ["#fail27"],
     ["#fail28"],
     ["#fail29"],
-    ["#fail30"],
     ["#fail35"],
     ["#fail36"],
     ["#fail37"],