fix(aria-required-children): allow menu as child of menu (#3820)

dequelabs · Dec 12, 2022 · a6569e5 · a6569e5
1 parent 07a5dad
commit a6569e5
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/lib/standards/aria-roles.js b/lib/standards/aria-roles.js
@@ -329,7 +329,13 @@ const ariaRoles = {
   },
   menu: {
     type: 'composite',
-    requiredOwned: ['group', 'menuitemradio', 'menuitem', 'menuitemcheckbox'],
+    requiredOwned: [
+      'group',
+      'menuitemradio',
+      'menuitem',
+      'menuitemcheckbox',
+      'menu'
+    ],
     allowedAttrs: [
       'aria-activedescendant',
       'aria-expanded',

diff --git a/test/integration/rules/aria-required-children/aria-required-children.html b/test/integration/rules/aria-required-children/aria-required-children.html
@@ -116,3 +116,14 @@
     <li><div role="radio"></div></li>
   </ul>
 </div>
+
+<ul role="menu" id="pass15">
+  <li role="none">
+    <a href="#" role="menuitem">Foo</a>
+    <ul role="menu" id="pass16">
+      <li role="none">
+        <a href="#" role="menuitem">Bar</a>
+      </li>
+    </ul>
+  </li>
+</ul>
diff --git a/test/integration/rules/aria-required-children/aria-required-children.json b/test/integration/rules/aria-required-children/aria-required-children.json
@@ -29,7 +29,9 @@
     ["#pass11"],
     ["#pass12"],
     ["#pass13"],
-    ["#pass14"]
+    ["#pass14"],
+    ["#pass15"],
+    ["#pass16"]
   ],
   "incomplete": [
     ["#incomplete1"],