fix(region): allow role=alertdialog as region (#2660)

dequelabs · Nov 25, 2020 · b928df7 · b928df7
1 parent f2f1537
commit b928df7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/checks/navigation/region.json b/lib/checks/navigation/region.json
@@ -2,7 +2,7 @@
   "id": "region",
   "evaluate": "region-evaluate",
   "options": {
-    "regionMatcher": "dialog, [role=dialog], svg, iframe"
+    "regionMatcher": "dialog, [role=dialog], [role=alertdialog], svg, iframe"
   },
   "metadata": {
     "impact": "moderate",

diff --git a/test/checks/navigation/region.js b/test/checks/navigation/region.js
@@ -274,6 +274,14 @@ describe('region', function() {
     assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
   });
 
+  it('treats role=alertdialog elements as regions', function() {
+    var checkArgs = checkSetup(
+      '<div role="alertdialog" id="target"><p>This is random content.</p></div><div role="main">Content</div>'
+    );
+
+    assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+  });
+
   it('treats svg elements as regions', function() {
     var checkArgs = checkSetup(
       '<svg id="target"></svg><div role="main">Content</div>'