Merge pull request #3729 from dequelabs/release-4.5.0

chore(release): 4.5.0
dequelabs · Oct 24, 2022 · d27488e · d27488e
2 parents 21a3e6a + 2a55e25
commit d27488e
Show file tree

Hide file tree

Showing 1,012 changed files with 41,893 additions and 15,788 deletions.
diff --git a/.babelrc b/.babelrc
@@ -1,9 +1,5 @@
 {
-  "presets": [
-    [
-      "@babel/preset-env"
-    ]
-  ],
+  "presets": ["@babel/preset-env"],
   "plugins": [
     [
       "@babel/plugin-proposal-object-rest-spread",
@@ -12,4 +8,4 @@
       }
     ]
   ]
-}
+}
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -5,19 +5,13 @@ defaults: &defaults
 
 unix_box: &unix_box
   docker:
-    - image: circleci/node:16.13-browsers
+    - image: cimg/node:16.14-browsers
 
 unix_nightly_box: &unix_nightly_box
   docker:
     - image: cimg/node:lts-browsers
 
-win_box: &win_box
-  executor:
-    name: win/default
-    shell: bash.exe
-
 orbs:
-  win: circleci/windows@2.2.0
   puppeteer: threetreeslight/puppeteer@0.1.2
   browser-tools: circleci/browser-tools@1.1.0
 
@@ -30,18 +24,13 @@ restore_dependency_cache_unix: &restore_dependency_cache_unix
       - v9-cache-unix-{{ checksum "package-lock.json" }}
       - v9-cache-unix-
 
-restore_dependency_cache_win: &restore_dependency_cache_win
-  restore_cache:
-    keys:
-      - v9-cache-win-{{ checksum "package-lock.json" }}
-      - v9-cache-win-
-
 jobs:
   # Fetch and cache dependencies.
   dependencies_unix:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *set_npm_auth
       - <<: *restore_dependency_cache_unix
@@ -51,18 +40,6 @@ jobs:
           key: v9-cache-unix-{{ checksum "package-lock.json" }}
           paths:
             - node_modules
-  dependencies_win:
-    <<: *defaults
-    <<: *win_box
-    steps:
-      - checkout
-      - <<: *set_npm_auth
-      - <<: *restore_dependency_cache_win
-      - run: npm ci
-      - save_cache:
-          key: v9-cache-win-{{ checksum "package-lock.json" }}
-          paths:
-            - node_modules
 
   # Run ESLINT
   lint:
@@ -78,37 +55,24 @@ jobs:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *restore_dependency_cache_unix
+      - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test -- --browsers Chrome,Firefox
       - run: npm run test:integration:chrome
       - run: npm run test:integration:firefox
 
-  # Run the test suite in IE in windows
-  test_win:
-    <<: *defaults
-    <<: *win_box
-    steps:
-      - checkout
-      # npm i or restore cache
-      - <<: *restore_dependency_cache_win
-      - run: npm run build
-      - run: npm run test -- --browsers IE
-      # install selenium
-      - run: |
-          choco install selenium-ie-driver --version 3.141.5
-          export PATH=/c/tools/selenium:$PATH
-          echo $PATH
-      - run: npm run test:integration:ie
-
   # Run examples under `doc/examples`
   test_examples:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *restore_dependency_cache_unix
+      - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test:examples
 
@@ -117,8 +81,10 @@ jobs:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *restore_dependency_cache_unix
+      - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test:act
 
@@ -127,8 +93,10 @@ jobs:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *restore_dependency_cache_unix
+      - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test:apg
 
@@ -137,8 +105,10 @@ jobs:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *restore_dependency_cache_unix
+      - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test:locales
 
@@ -147,8 +117,10 @@ jobs:
     <<: *defaults
     <<: *unix_box
     steps:
+      - browser-tools/install-browser-tools
       - checkout
       - <<: *restore_dependency_cache_unix
+      - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test:virtual-rules
 
@@ -184,7 +156,7 @@ jobs:
       # install ACT rules
       # install first as for some reason installing a single package
       # also re-installs all repo dependencies as well
-      - run: npm install act-rules/act-rules.github.io#master
+      - run: npm install w3c/wcag-act-rules#main
       - run: npx browser-driver-manager install chromedriver --verbose
       - run: npm run build
       - run: npm run test:act
@@ -299,7 +271,6 @@ workflows:
     jobs:
       # install deps
       - dependencies_unix
-      - dependencies_win
       # Run linting
       - lint:
           requires:
@@ -308,10 +279,6 @@ workflows:
       - test_unix:
           requires:
             - lint
-      # Run IE/ Windows test on all commits
-      - test_win:
-          requires:
-            - dependencies_win
       - test_examples:
           requires:
             - test_unix
@@ -341,7 +308,6 @@ workflows:
           type: approval
           requires:
             - test_unix
-            - test_win
             - test_examples
             - test_locales
             - test_virtual_rules
@@ -399,7 +365,7 @@ workflows:
     triggers:
       - schedule:
           # run at 00:00 UTC every day
-          cron: "0 0 * * *"
+          cron: '0 0 * * *'
           filters:
             branches:
               only:
@@ -414,4 +380,4 @@ workflows:
             - dependencies_unix
       - test_nightly_aria_practices:
           requires:
-            - dependencies_unix
+            - dependencies_unix
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -71,10 +71,7 @@ module.exports = {
   overrides: [
     {
       files: ['lib/**/*.js'],
-      excludedFiles: [
-        'lib/core/reporters/**/*.js',
-        'lib/**/*-after.js'
-      ],
+      excludedFiles: ['lib/core/reporters/**/*.js', 'lib/**/*-after.js'],
       parserOptions: {
         sourceType: 'module'
       },
@@ -94,10 +91,7 @@ module.exports = {
     },
     {
       // after functions and reporters will not be run inside the same context as axe.run so should not access browser globals that require context specific information (window.location, window.getComputedStyles, etc.)
-      files: [
-        'lib/**/*-after.js',
-        'lib/core/reporters/**/*.js'
-      ],
+      files: ['lib/**/*-after.js', 'lib/core/reporters/**/*.js'],
       parserOptions: {
         sourceType: 'module'
       },
@@ -110,18 +104,16 @@ module.exports = {
       }
     },
     {
-      files: [
-        'test/aria-practices/**/*.js'
-      ],
+      files: ['test/act-rules/**/*.js', 'test/aria-practices/**/*.js'],
       env: {
         mocha: true
       }
     },
     {
       files: ['test/**/*.js'],
-      excludedFiles: 'test/aria-practices/**/*.js',
+      excludedFiles: ['test/act-rules/**/*.js', 'test/aria-practices/**/*.js'],
       parserOptions: {
-        ecmaVersion: 5
+        ecmaVersion: 2021
       },
       env: {
         browser: true,

diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
@@ -0,0 +1,4 @@
+contact_links:
+  - name: Join the axe Slack Community
+    url: https://accessibility.deque.com/axe-community
+    about: Connect with other people passionate about digital accessibility and axe tools.
diff --git a/.github/ISSUE_TEMPLATE/documentation.yml b/.github/ISSUE_TEMPLATE/documentation.yml
@@ -0,0 +1,25 @@
+name: Improve our documentation
+description: Report issues in our documentation or things we could document better.
+labels: ['docs', 'ungroomed']
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Documentation reports can be made for axe-core, [axe Extension](https://www.deque.com/axe/browser-extensions/), and [axe Linter](https://marketplace.visualstudio.com/items?itemName=deque-systems.vscode-axe-linter). If you have a documentation report for one of our npm integrations (e.g. `@axe-core/webdriverjs`), please open an issue in https://github.com/dequelabs/axe-core-npm.
+  - type: dropdown
+    id: product
+    attributes:
+      label: Product
+      description: Which product is the documentation report for?
+      options:
+        - axe-core
+        - axe Extension
+        - axe Linter
+    validations:
+      required: true
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+    validations:
+      required: true
diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml
@@ -0,0 +1,26 @@
+name: Request a feature
+description: Request an enhancement, improvement, or new rule.
+labels: ['feat', 'ungroomed']
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Feature requests can be made for axe-core, [axe Extension](https://www.deque.com/axe/browser-extensions/), and [axe Linter](https://marketplace.visualstudio.com/items?itemName=deque-systems.vscode-axe-linter). If you have a feature request for one of our npm integrations (e.g. `@axe-core/webdriverjs`), please open an issue in https://github.com/dequelabs/axe-core-npm.
+  - type: dropdown
+    id: product
+    attributes:
+      label: Product
+      description: Which product is the feature for?
+      options:
+        - axe-core
+        - axe Extension
+        - axe Linter
+    validations:
+      required: true
+  - type: textarea
+    id: description
+    attributes:
+      label: Feature Description
+      description: What do you wish the product did? If the feature is about adding a new rule to axe-core, please follow our [rule template](https://github.com/dequelabs/axe-core/blob/develop/doc/rule-proposal.md).
+    validations:
+      required: true