fix(button-name): work with serial virtual node (#2351)

dequelabs · Jul 9, 2020 · efa0e56 · efa0e56
1 parent 63ca388
commit efa0e56
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/checks/shared/button-has-visible-text.json b/lib/checks/shared/button-has-visible-text.json
@@ -5,7 +5,8 @@
 		"impact": "critical",
 		"messages": {
 			"pass": "Element has inner text that is visible to screen readers",
-			"fail": "Element does not have inner text that is visible to screen readers"
+			"fail": "Element does not have inner text that is visible to screen readers",
+			"incomplete": "Unable to determine if element has children"
 		}
 	}
 }
diff --git a/test/checks/shared/button-has-visible-text.js b/test/checks/shared/button-has-visible-text.js
@@ -52,4 +52,16 @@ describe('button-has-visible-text', function() {
 				.apply(checkContext, checkArgs)
 		);
 	});
+
+	describe('SerialVirtualNode', function() {
+		it('should return undefined if no other attributes are provided', function() {
+			var node = new axe.SerialVirtualNode({
+				nodeName: 'button'
+			});
+
+			assert.isUndefined(
+				axe.testUtils.getCheckEvaluate('has-visible-text')(null, {}, node)
+			);
+		});
+	});
 });