Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldset check should not prioritise fieldset over aria group #1315

Closed
WilcoFiers opened this issue Jan 16, 2019 · 1 comment · Fixed by #1640
Closed

fieldset check should not prioritise fieldset over aria group #1315

WilcoFiers opened this issue Jan 16, 2019 · 1 comment · Fixed by #1640
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

This shouldn't fail the checkboxgroup rule:

<fieldset>
	<div role="group" aria-label="Group label">
		<input type="checkbox" name="foo" />
		<input type="checkbox" name="foo" />
	</div>
</fieldset>

Might be best to simply put the ARIA grouping code into its own check, rather than have it be part of the fieldset check. We need to think through the implications of that, but it would sure clear up the code in that check.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Jan 16, 2019
@WilcoFiers WilcoFiers added this to the Axe-core 3.4 milestone Jun 7, 2019
@dylanb
Copy link
Contributor

dylanb commented Jun 16, 2019

doesn't seem high priority to me. Also needs some thought/testing, what about:

<fieldset>
        <legend>I don't like groups</legend>
	<div role="group" aria-label="Group label">
		<input type="checkbox" name="foo" />
		<input type="checkbox" name="foo" />
	</div>
</fieldset>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants