Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDOM example / improve test coverage for JSDOM #1473

Closed
WilcoFiers opened this issue Apr 4, 2019 · 1 comment
Closed

Add JSDOM example / improve test coverage for JSDOM #1473

WilcoFiers opened this issue Apr 4, 2019 · 1 comment
Assignees
Labels
docs Documentation changes

Comments

@WilcoFiers
Copy link
Contributor

We recently had a problem when we accidentally introduced a new global variable. To avoid this, we should have a JSDOM example that explicitly sets the required global variables. This serves both as documentation on how to use JSDOM, and as a way to prevent us accidentally adding new required globals.

@WilcoFiers WilcoFiers added the docs Documentation changes label Apr 4, 2019
@straker straker self-assigned this May 1, 2019
@aellsey aellsey added this to the HTMLTools Sprint 2 milestone May 6, 2019
@WilcoFiers WilcoFiers removed this from the HTMLTools Sprint 2 milestone May 8, 2019
@padmavemulapati
Copy link

QA reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation changes
Projects
None yet
Development

No branches or pull requests

4 participants