fix(multiple-label): considers explicit labels in the same shadow tree #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoSponge
commented
May 23, 2019
AutoSponge
force-pushed
the
fix-1559
branch
7 times, most recently
from
6fd0915
to
4426f49
Compare
WilcoFiers
previously requested changes
May 24, 2019
WilcoFiers
approved these changes
May 24, 2019
|
Verified behaving as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the node is not contained in the ownerDocument it must be in shadow (open). Therefore, we climb the parentNode path to the first document fragment. Closed shadow is not supported. This fixes an issue where a single shadow tree held an input and valid label(s). Crossing shadow tree/document boundaries can not produce an accessible name.
Closes issue: #1559
Reviewer checks
Required fields, to be filled out by PR reviewer(s)