Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing types #1696

Closed
frontned opened this issue Jul 11, 2019 · 0 comments · Fixed by #1697
Closed

Missing types #1696

frontned opened this issue Jul 11, 2019 · 0 comments · Fixed by #1697

Comments

@frontned
Copy link
Contributor

Expectation: RunOptions interface should contain all of the options from the documentation:
https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#options-parameter

Actual: Now RunOptions interface is missing some properties, like: reporter, xpath, absolutePaths, restoreScroll, frameWaitTime, preload, performanceTimer

Motivation: So TypeScript would be happy.

image
@frontned frontned mentioned this issue Jul 12, 2019
Merged
4 tasks
straker pushed a commit that referenced this issue Jul 12, 2019
@frontned @straker
fix(types): add new properties to RunOptions (#1697)
02aa36c 
Added new properties to RunOptions interface that are specified in documentation: https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#options-parameter

    Closes #1696
WilcoFiers pushed a commit that referenced this issue Jul 22, 2019
@frontned @WilcoFiers
fix(types): add new properties to RunOptions (#1697)
ff7b73f 
Added new properties to RunOptions interface that are specified in documentation: https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#options-parameter

    Closes #1696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): add new properties to RunOptions
1 participant
@frontned