Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add new properties to RunOptions #1697

Merged
merged 1 commit into from Jul 12, 2019
Merged

fix(types): add new properties to RunOptions #1697

merged 1 commit into from Jul 12, 2019

Conversation

frontned
Copy link
Contributor

@frontned frontned commented Jul 11, 2019 •
edited by straker

Added new properties to RunOptions interface that are specified in documentation: https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#options-parameter

Closes #1696

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: << Name here >>

@frontned
fix(types): add new properties to RunOptions
852711c 
  Added new properties to RunOptions interface that are specified in documentation: https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#options-parameter

    Closes #1696
@frontned frontned requested a review from a team as a code owner July 11, 2019 06:54
@CLAassistant
Copy link

CLAassistant commented Jul 11, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

MKrupauskas
MKrupauskas approved these changes Jul 12, 2019
View reviewed changes
Copy link

@MKrupauskas MKrupauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, same option is bugging our typescript validation and failing our build. I hope we can merge this ASAP.

straker
straker approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR!

@straker straker merged commit 02aa36c into dequelabs:develop Jul 12, 2019
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
@frontned @WilcoFiers
fix(types): add new properties to RunOptions (#1697)
ff7b73f 
Added new properties to RunOptions interface that are specified in documentation: https://www.deque.com/axe/axe-for-web/documentation/api-documentation/#options-parameter

    Closes #1696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

@MKrupauskas MKrupauskas MKrupauskas approved these changes

@grieblius grieblius grieblius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types
5 participants
@frontned @CLAassistant @straker @MKrupauskas @grieblius