Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to aria.getRole to ignore presentation and none roles #1792

Closed
straker opened this issue Aug 29, 2019 · 2 comments
Closed

Add option to aria.getRole to ignore presentation and none roles #1792

straker opened this issue Aug 29, 2019 · 2 comments
Labels
core Issues in the core code (lib/core) feat New feature or enhancement good first issue For first-time contributors hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/

Comments

@straker
Copy link
Contributor

straker commented Aug 29, 2019 •
edited
Loading

We do a lot of !['presentation', 'none'].includes(role) in the code. It would be nice to add an option to aria.getRole to ignore these roles. An option named noPresentational should suffice. If the option is set, the function should return null if the role is either presentation or none.

Please also create a test to show that the new option works.
@straker straker added core Issues in the core code (lib/core) feat New feature or enhancement labels Aug 29, 2019
@straker straker mentioned this issue Aug 29, 2019
Merged
2 tasks
@straker straker added the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Oct 11, 2019
@straker straker mentioned this issue Oct 18, 2019
Closed
2 tasks
@straker straker added help wanted We welcome PRs or discussions for issues marked as help wanted and removed hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ labels Jul 29, 2020
@straker straker added good first issue For first-time contributors and removed help wanted We welcome PRs or discussions for issues marked as help wanted labels Aug 20, 2020
@straker straker added the hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ label Oct 1, 2020
@codingLogan
Copy link
Contributor

If it's not already being worked on, I think I'll give this one a shot.

@straker
Copy link
Contributor Author

straker commented Oct 5, 2020

All yours. Let me know if you need anything.

@codingLogan codingLogan mentioned this issue Oct 9, 2020
Merged
2 tasks
WilcoFiers pushed a commit that referenced this issue Oct 15, 2020
@codingLogan
feat(get-role): add noPresentational option (#2549)
4f39299 
Add option to getRole to return null if 'presentation' or 'none'
would be returned

Closes issue #1792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues in the core code (lib/core) feat New feature or enhancement good first issue For first-time contributors hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @straker @codingLogan