get-background-color Does not reset horizontal scroll

[emilyrohrbough]

summary

#1845 was merged & released to

[check] if the center point of the element is within the viewport and if not, look for a scrollable parent element and scroll it.

This feature introduces the bug where it does not reset the horizontal scroll after the test is complete.

Expectation:

Horizontal content is scrolled and is restored to its initial state.

Actual:

Horizontal content is scrolled and is not restored to its initial state.

More Info

We use axe to run accessibly and visual regression on test pages. The following screenshot shows the before (deleted) and after (added) visuals. Before is running axe 3.2.0 on the page then taking a screenshot. After is running axe with 3.4.0.

axe-core version: 3.4.0
~axe-webdriver, extension or other integration version: X.Y.Z~

Browser and Assistive Technology versions

For Tooling issues:
- Node version: v10.17.0
- Platform:  Mac

[straker]

Thanks for letting us know. We're working on a major change to the color-contrast rule should fix this issue.

[benbcai]

@straker After taking a closer look at the cause of the issue presented in the above screenshot, it is not #1845 that introduced the issue. It was the change made on #1599 that caused this. I tested our application without that change and I continue to get the before (deleted) screenshot and our tests passed. Once I included the check for the hidden overflow style from #1599, then I get the after (added) screenshot.

Our application has another test example that also failed because the overflow style on its element is hidden. It appears to me that these hidden overflow elements initially get scrolled to a different position but do not get restored back to the original top-left position because the scrollableX and scrollableY variables here no longer evaluate to true

I don't know what is the best way to fix this. #1599 was for fixing issue #1730. Is there another potential solution to address #1730?

[jeankaplansky]

ID'd as color-contrast issue. We're going to make one entry into the release notes for all color-contrast fixes/enhancements.

[benbcai]

@jeankaplansky @straker Would it make issue tracking easier if I log a separate issue for the root cause of the issue I mentioned above relating to the changes made in #1599? The color-contrast fixes/enhancements you're making would not fix the issue this issue.

[straker]

Ya, this issue has already been flagged as fixed, so probably best to create a new issue to track it.

[benbcai]

@straker @jeankaplansky I logged #1979 to restore scrolling for elements with hidden overflow style. Can you please review and prioritize as this issue is preventing my team from upgrading to V3.4.0 to fix other issues?

[padmavemulapati]

Larger pages also not taking more than 11s , attached screenshot