Scrolling position for elements with hidden overflow style are no longer restored

[benbcai]

Summary

Our application uses axe-core to run accessibly and visual regression on test pages. When running axe we set the restoreScroll option to true to restore the scrolling position.

This is how our test page used to look when using axe-core 3.2.2.

However, after upgrading to axe-core 3.3.0 or 3.4.0, our test page now looks like this:

The container element on this test page has an overflow-x and overflow-y style of hidden. The changes made on #1599 (released on axe-core 3.3.0) appears to no longer restore hidden elements back to their original position using elm.scrollTop.

See this comment on #1951 for additional details.

Expectation:

To restore elements with an overflow style of hidden back to their original position

Actual:

Elements with an overflow style of hidden are scrolled to a different position but are not restored.

axe-core version: 3.4.0

Browser and Assistive Technology versions

For Tooling issues:
- Node version: v10.17.0
- Platform:  Mac

[WilcoFiers]

Hmm, that's very odd. Thank you for reporting. For axe-core 3.5, which we're planning to release in a month, axe-core will no longer be scrolling at all. So this problem should go away soon.

[straker]

If you manually run axe using https://unpkg.com/axe-core@next/axe.js, does it give you issues with the scroll?

[benbcai]

@WilcoFiers @straker I pulled down the develop branch that includes the changes from #1943 and this issue is resolved. I'll close this issue. I'm seeing other failures (unrelated to this issue) when using the develop branch but I'll investigate further.