Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): add reviewOnFail option to have rule return as needs review instead of violation #2235

Merged
merged 1 commit into from
May 18, 2020
Merged

feat(rule): add reviewOnFail option to have rule return as needs review instead of violation #2235

merged 1 commit into from
May 18, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented May 15, 2020 •
edited by WilcoFiers
Loading

Closes issue: #2186

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner May 15, 2020 16:22
@straker straker merged commit bb72acd into develop May 18, 2020
@straker straker deleted the review-on-fail branch May 18, 2020 14:29
@emilyrohrbough emilyrohrbough mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers